Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consult-outline account for folding #21

Closed
Luis-Henriquez-Perez opened this issue Dec 1, 2020 · 2 comments
Closed

Make consult-outline account for folding #21

Luis-Henriquez-Perez opened this issue Dec 1, 2020 · 2 comments
Labels
feature New feature or request

Comments

@Luis-Henriquez-Perez
Copy link

If the headline you choose for consult outline is folded, consult outline does not do what I would expect. If I choose the headline, I'd expect it to unfold the minimal amount necessary to view the headline. Instead, I'm taken to the top level headline. I can create a pull request on this as I do have code that worked for me to fix this.

@minad
Copy link
Owner

minad commented Dec 1, 2020

Yes, please show the code! As of now consult outline is simply presenting a flat list of the available headings. It does not yet interact with folded code in any way. But I agree it would be nice if unfolding would work during preview and when jumping to the line after selection.

@minad minad added the feature New feature or request label Dec 1, 2020
@minad
Copy link
Owner

minad commented Dec 2, 2020

@Luis-Henriquez-Perez I should add - even if you don't have perfectly polished code you can push it here as a draft PR. I am not sure how to integrate folding with consult, since I didn't look how folding is implemented behind the scenes. Some draft code would in case be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants