Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary logging for TLS related spurious errors of io.EOF #107

Closed
harshavardhana opened this issue Jun 7, 2024 · 4 comments · Fixed by #109
Closed

Avoid unnecessary logging for TLS related spurious errors of io.EOF #107

harshavardhana opened this issue Jun 7, 2024 · 4 comments · Fixed by #109
Assignees
Labels
community all incoming issues fixed triage all incoming issues in triage

Comments

@harshavardhana
Copy link
Member

harshavardhana commented Jun 7, 2024

Expected Behavior

No such logs.

Current Behavior

Jun 06 22:22:37 xxxxxxx sidekick[3647762]: 2024/06/06 22:22:37 http: TLS handshake error from 10.20.103.9:50531: EOF
Jun 06 22:22:37 xxxxxxx sidekick[3647762]: 2024/06/06 22:22:37 http: TLS handshake error from 10.21.199.9:32391: EOF
Jun 06 22:22:38 xxxxxxx sidekick[3647762]: 2024/06/06 22:22:38 http: TLS handshake error from 10.20.135.13:11299: EOF

Possible Solution

Check MinIO server implementation which implements a workaround by providing a custom

http.Server.ErrorLog (function) that discards the logs originating from net/http, we need
to turn this off otherwise these messages clobber up --json output in some environments.

@harshavardhana harshavardhana added community all incoming issues triage all incoming issues in triage labels Jun 7, 2024
@jiuker
Copy link
Contributor

jiuker commented Jun 11, 2024

Have you a quickly steps to reproduce this? @harshavardhana

@harshavardhana
Copy link
Member Author

you need to configure TLS on MinIO and TLS at sidekick and send a bunch of requests to sidekick using warp put

@jiuker
Copy link
Contributor

jiuker commented Jun 12, 2024

log.New(io.Discard, "", 0) minio do that.

@harshavardhana
Copy link
Member Author

log.New(io.Discard, "", 0) minio do that.

that is exactly what we need :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community all incoming issues fixed triage all incoming issues in triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants