Update tflint references

[dms1981]

User Story

As a Modernisation Platform Engineer
I want to update our tflint workflows
So that we can actively use tflint as part of our secure code analysis

User Type(s)

Modernisation Platform Engineer

Value

In a recent update the tflint tool used in our code-scanning.yml workflows has updated to a version which reports errors with our configured usage:

Running tflint in .
Command line arguments support was dropped in v0.47. Use --chdir or --filter instead.
tflint_exitcode=1

We should update our code-scanning.yml workflows across repositories to fix this error.
From a quick check of my local copies of modernisation platform repositories I could see around 83 separate uses of this action in yaml files.

You can see the release where the command line arguments were deprecated here: https://github.com/terraform-linters/tflint/releases/tag/v0.47.0

The pull request that shows the deprecations being implemented is available here: terraform-linters/tflint#1687

Assumptions / Hypothesis / Questions / Unknowns

Definition of done

• solution found and applied for one repository
• solution applied consistently across team repositories via scripting
• another team member has reviewed
• tflint / secure code analysis checks pass without deprecation error

Reference

How to write good user stories

[ASTRobinson]

after investigating the issue I have discovered that this was resolved under PR ministryofjustice/github-actions#202 and am therefore closing this issue.