Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTHORS.md, HISTORY.md and LICENSE installed outside the packages #416

Closed
albamig opened this issue Apr 29, 2022 · 4 comments · Fixed by #448
Closed

AUTHORS.md, HISTORY.md and LICENSE installed outside the packages #416

albamig opened this issue Apr 29, 2022 · 4 comments · Fixed by #448

Comments

@albamig
Copy link
Contributor

albamig commented Apr 29, 2022

We have been facing an issue while downgrading packages within our Docker images related to AUTHORS.md not being found.

The problem is that the following pyproject configuration adds those files to the wheel distribution but outside the package itself.
If you download the wheel and take a look, they are outside of minos.
Another way to see the problem is by running pip -V and moving to the installation directory. The files are there among each other package.

Since the LICENSE already gets imported within the wheel distribution info and the other packages aren't actually important for distribution, I propose to delete that pyproject configuration.

@garciparedes
Copy link
Member

This issue is closely related to python-poetry/poetry#2015

@garciparedes garciparedes self-assigned this May 3, 2022
@garciparedes
Copy link
Member

I'll fix this issue following a similar approach to pavdmyt/yaspin#135

@garciparedes garciparedes added this to the v0.7.x milestone May 3, 2022
garciparedes pushed a commit that referenced this issue May 3, 2022
* Fix bug related with `poetry`'s `include`.
@garciparedes garciparedes linked a pull request May 3, 2022 that will close this issue
garciparedes pushed a commit that referenced this issue May 3, 2022
…-bug

#416 - Fix bug related with `poetry`'s `include`
@cmungall
Copy link

Hello, I arrived here from the linked poetry issue as I am having a similar issue to the one you resolved.

Did you fix using the magical sdist work to your satisfaction?

I noticed that when I installed minos-microservice-cqrs there is no HISTORY.md file included at all,

The source distribution looks like this:

tar -ztf ~/Downloads/minos-microservice-cqrs-0.7.0.tar.gz
minos-microservice-cqrs-0.7.0/AUTHORS.md
minos-microservice-cqrs-0.7.0/HISTORY.md
minos-microservice-cqrs-0.7.0/LICENSE
minos-microservice-cqrs-0.7.0/README.md
minos-microservice-cqrs-0.7.0/minos/cqrs/init.py
minos-microservice-cqrs-0.7.0/minos/cqrs/exceptions.py
minos-microservice-cqrs-0.7.0/minos/cqrs/handlers.py
minos-microservice-cqrs-0.7.0/minos/cqrs/services.py
minos-microservice-cqrs-0.7.0/pyproject.toml
minos-microservice-cqrs-0.7.0/setup.py
minos-microservice-cqrs-0.7.0/PKG-INFO

with the files at the top level

the wheel omits these altogether:

tar -ztf ~/Downloads/minos_microservice_cqrs-0.7.0-py3-none-any.whl
minos/cqrs/init.py
minos/cqrs/exceptions.py
minos/cqrs/handlers.py
minos/cqrs/services.py
minos_microservice_cqrs-0.7.0.dist-info/LICENSE
minos_microservice_cqrs-0.7.0.dist-info/WHEEL
minos_microservice_cqrs-0.7.0.dist-info/METADATA
minos_microservice_cqrs-0.7.0.dist-info/RECORD

is this what you intended?

@albamig
Copy link
Contributor Author

albamig commented May 21, 2022

Right! That's what we meant to do.

All of our Minos packages (cqrs, common, networks...) have those files. We don't mind to put them within the sdist because we never install from it. The problem comes just when putting them within the wheel, since if more than one of Minos packages get installed using pip, there is a conflicting overriding of those files at the root level.

Does this solve your issue? Don't hesitate to ask further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment