Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the networks #3

Open
tailongnguyen opened this issue Aug 7, 2018 · 0 comments
Open

Update the networks #3

tailongnguyen opened this issue Aug 7, 2018 · 0 comments

Comments

@tailongnguyen
Copy link

tailongnguyen commented Aug 7, 2018

Hi, thanks for your great work
I have one question about the weight updating protocol.
The gradients of the local network (including all auxiliary tasks) are applied in the process function in trainer.py. However, I notice that the sync function (which copies the weights of global network to the local one) is ran BEFORE the apply_gradient is ran (line 354 and 409 respectively).
Following the code behind these 2 functions, you are copying the shared weights to the local network (so basically the global variables and local variables will be the same by then), then calculating gradients on local variables, then applying the gradients to the global variables. It does not sound logic, does it?

Please correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant