From d4c230895c56b26319eb1844408108f8ebdd0f0f Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 30 Jul 2024 14:07:40 +0200 Subject: [PATCH] clearer comment about values being loaded by get_state --- kubespawner/spawner.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/kubespawner/spawner.py b/kubespawner/spawner.py index f30cc670..b3649a2f 100644 --- a/kubespawner/spawner.py +++ b/kubespawner/spawner.py @@ -187,8 +187,14 @@ def __init__(self, *args, **kwargs): # By now, all the traitlets have been set, so we can use them to # compute other attributes - # namespace, pod_name, dns_name are persisted in state + # namespace, pod_name, etc. are persisted in state + # so values set here are only _default_ values. + # If this Spawner has ever launched before, + # these values will be be overridden in `get_state()` + # # these same assignments should match clear_state + # for transitive values (pod_name, dns_name) + # but not persistent values (namespace, pvc_name) if self.enable_user_namespaces: self.namespace = self._expand_user_properties( self.user_namespace_template, slug_scheme="safe"