Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick styling fixes for the current filters #3274

Closed
Tracked by #3084
NoemiOverdijk opened this issue Jul 22, 2024 · 3 comments · Fixed by #3322
Closed
Tracked by #3084

Quick styling fixes for the current filters #3274

NoemiOverdijk opened this issue Jul 22, 2024 · 3 comments · Fixed by #3322
Assignees

Comments

@NoemiOverdijk
Copy link

NoemiOverdijk commented Jul 22, 2024

This design has been approved and is ready to be implemented.
You can find more details about the design in the Approved | Patterns file.

Image


Since the new filter design is out of scope for the MVP, we want to make the current filtering a bit more user friendly with some (hopefully) quick styling fixes.

Current styling

Image
Image

@NoemiOverdijk
Copy link
Author

This design is ready to be reviewed. You can find the design in the For Review | Patterns file.

@HeleenSG
Copy link
Contributor

HeleenSG commented Aug 7, 2024

@NoemiOverdijk I've updated the PR based on your feedback. Which adds:

  • Border bottom when the filters are opened
  • Moves the chevron to the left

@Rieven I've updated the pr description with the todo's. Which mainly include adding the counter to other filters.

@NoemiOverdijk NoemiOverdijk removed their assignment Aug 7, 2024
@NoemiOverdijk
Copy link
Author

@HeleenSG Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants