Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_egfxset.py is failing due to librosa API change #578

Closed
dagett opened this issue Feb 25, 2023 · 1 comment
Closed

test_egfxset.py is failing due to librosa API change #578

dagett opened this issue Feb 25, 2023 · 1 comment

Comments

@dagett
Copy link

dagett commented Feb 25, 2023

The test tests/datasets/test_egfxset.py is failing in checks for #576 #577. The test fails where the latest version of librosa 0.10.0 is used - py37 and py38 but not for py36 which is not supported by librosa so uses the old release, version 0.9.2.

It seems the call inside mirdata/annotations.py to librosa.hz_to_note() in latest librosa returns a ndarray instead as for 0.9.2, a list. The test expects a list so fails its assert in tests/test_utils.py and run_track_tests().

There might be many ways to fix this, a short-term one is to lock librosa to version 0.9.2, that should should allow test_egfxset.py to get the expected datatype for all Python versions, and pass those tests. Another is to remove support for Python 3.6 (already EOL) and update the test.

@dagett dagett mentioned this issue Feb 25, 2023
15 tasks
@genisplaja
Copy link
Collaborator

Hey @dagett! Thank you very much for bringing this up last month. That helped a lot! We will be removing 3.6 support and moving to 3.9 (and maybe 3.10 soon) to address this problem. I am closing this issue, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants