Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link for "OMRAS2 Metadata Project 2009" #555

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

CyxouD
Copy link
Contributor

@CyxouD CyxouD commented Aug 24, 2022

A previous link for "OMRAS2 Metadata Project 2009" gives "404 Not found error", I replaced it with the one from the CiteSeerX.

CyxouD and others added 2 commits August 24, 2022 14:22
A previous link for "OMRAS2 Metadata Project 2009" gives "404 Not found error", I replaced it with the one from the CiteSeerX.
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #555 (e4c0b09) into master (496eb4a) will increase coverage by 0.04%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   96.96%   97.00%   +0.04%     
==========================================
  Files          58       58              
  Lines        6990     6987       -3     
==========================================
  Hits         6778     6778              
+ Misses        212      209       -3     

@harshpalan
Copy link
Collaborator

Hi @CyxouD, thank you for noticing this issue. The updated link is not working for us. Can you please check once from your side?

Also does this link contain the same paper as mentioned previously? Do let us know. Thanks :)

@genisplaja
Copy link
Collaborator

hey everyone! I actually checked and both the links you provided and the one proposed by @harshpalan work, and they point to the same paper. I am merging master, probably some checks will fail because of problems in master, we will be working on that these days and get this merged ASAP.

@guillemcortes guillemcortes added the broken link The dataset is currently not accessible for download label Oct 31, 2023
Copy link
Collaborator

@genisplaja genisplaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link works, thanks @CyxouD!

@genisplaja genisplaja merged commit e3c34a5 into mir-dataset-loaders:master Oct 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken link The dataset is currently not accessible for download
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants