-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for (Compmusic) Carnatic Music Rhythm #560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 96.79% 96.81% +0.01%
==========================================
Files 53 54 +1
Lines 6499 6619 +120
==========================================
+ Hits 6291 6408 +117
- Misses 208 211 +3 |
Hi @nkundiushuti, @magdalenafuentes and @harshpalan. As discussed the last week, I got this dataloader done using the optional dependencies as usual. Do you have any idea why the docs are not rendering properly? I went through the raw but I cannot find any specific error there. Regarding the rest of TODOS, looks like this is ready to be reviewed :) |
try: | ||
from openpyxl import load_workbook as get_xlxs | ||
except ImportError: | ||
logging.error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this is not covered by test? is this to be compliant with what Harsh is doing on partial dependency checks? maybe we could have a global test for that
Adding loader for (Compmusic) Carnatic Music Rhythm
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset.