-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for BAF dataset #583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 96.84% 96.88% +0.04%
==========================================
Files 56 57 +1
Lines 6717 6816 +99
==========================================
+ Hits 6505 6604 +99
Misses 212 212 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @guillemcortes, I am just leaving a few tiny comments but the loader looks really nice. Good coverage, docs rendering correctly, and tests passing :) I'll invite @nkundiushuti, @magdalenafuentes, and @harshpalan to take a look, and IMO we can merge!
Hi @genisplaja, thanka for your comments, I've done the according modifications. I've also improved the csv2pandas management and atomized the function. I think now it's better. I've also included the corresponding test. Would you mind checking it? Thanks! |
That's nice! That is ready to go in my opinion. Thanks @guillemcortes :) Maybe @harshpalan or @magdalenafuentes could take a look? 🙏🏼🙏🏼🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @guillemcortes @genisplaja sorry for the delayed response. This looks good. I'm approving the changes, please go ahead and merge it. Thanks.
Adding loader for BAF
Please use the following title: "Adding loader for MyDATASET". If your pull request is work in progress, change your title to "[WIP] Adding loader for MyDATASET" to avoid reviews while the loader is not ready.
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset.If your dataset is not fully downloadable there are two extra steps you should follow:
pytest -s tests/test_full_dataset.py --local --dataset my_dataset
once on your dataset locally and confirmed it passesPlease-do-not-edit flag
To reduce friction, we will make commits on top of contributor's pull requests by default unless they use the
please-do-not-edit
flag. If you don't want this to happen don't forget to add the flag when you start your pull request.