Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rtx CI for PRs #37

Closed
kachick opened this issue Feb 23, 2023 · 2 comments · Fixed by #40
Closed

Run rtx CI for PRs #37

kachick opened this issue Feb 23, 2023 · 2 comments · Fixed by #40

Comments

@kachick
Copy link
Contributor

kachick commented Feb 23, 2023

Currently, only scheduled triggers exist because specifying a git-ref is not official.
I'll update after jdx/mise#164.

3799033#diff-5213986343ba5b14a2a002e79125d1b377df7e1f3b1c032ac2a1645ee6ebe2c9R3-R6
3799033#diff-5213986343ba5b14a2a002e79125d1b377df7e1f3b1c032ac2a1645ee6ebe2c9R33-R34

jdx/mise#182 direction is very good, but testing on the plugin side is also useful, I think.

@jdx
Copy link
Member

jdx commented Feb 23, 2023

I need to implement this: https://asdf-vm.com/plugins/create.html#testing-plugins

EDIT: created jdx/mise#191 to track

@kachick
Copy link
Contributor Author

kachick commented Feb 24, 2023

That will help me a lot! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants