Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari not playing videos due to missing functions when using /files #12881

Closed
1 task
Mar0xy opened this issue Jan 1, 2024 · 2 comments · Fixed by #12925 or #13712
Closed
1 task

Safari not playing videos due to missing functions when using /files #12881

Mar0xy opened this issue Jan 1, 2024 · 2 comments · Fixed by #12925 or #13712
Labels
⚠️bug? This might be a bug

Comments

@Mar0xy
Copy link
Contributor

Mar0xy commented Jan 1, 2024

💡 Summary

We got a report on our fork that safari does not play videos due to the videos missing a byte range header and another function with a ton of information about them: https://git.joinsharkey.org/Sharkey/Sharkey/issues/292

Copy and Pasted from linked issue:

(I don't know if this affects S3 storage as well)
Starting playback of any video hosted in /files does not work in Safari or any browser on iOS/iPadOS. This also affects Safari on macOS.
Safari requires Byte-Range support for video playback, see the Safari Web Content Guide.
Setting some headers is not enough, since Safari actually first sends a request for bytes 0-1 and then checks the response.

Here is another writeup of this behaviour, although there are many others.

🥰 Expected Behavior

Videos should play

🤬 Actual Behavior

Videos do not play

📝 Steps to Reproduce

  1. Open any video on safari

💻 Frontend Environment

From reporting user:

* Model and OS of the device(s): iPhone 15, iOS 17.2.1
* Browser: Safari / AppleWebKit 605.1.15
* Server URL: shonk.social
* Sharkey: 2023.12.0 (equivalent to Misskey 2023.12.2)

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@Mar0xy Mar0xy added the ⚠️bug? This might be a bug label Jan 1, 2024
@Mar0xy Mar0xy changed the title Safari not playing videos due to missing header Safari not playing videos due to missing header when using /files Jan 1, 2024
@Mar0xy Mar0xy changed the title Safari not playing videos due to missing header when using /files Safari not playing videos due to missing functions when using /files Jan 1, 2024
@kakkokari-gtyih
Copy link
Contributor

Working on it in #12909

@kakkokari-gtyih
Copy link
Contributor

Misskey本体の実装としては完了(メディアプロキシにはバイトレンジリクエストが実装されていないので別途対応する必要あり
misskey-dev/media-proxy#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
2 participants