Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary request to admin endpoint is sent even if you are not moderator when open page /instance-info/{host} #13919

Closed
1 task
zyoshoka opened this issue May 31, 2024 · 0 comments · Fixed by #14515
Labels
⚠️bug? This might be a bug

Comments

@zyoshoka
Copy link
Contributor

💡 Summary

/instance-info/{host} ページを開くとモデレーターでなくても /api/admin/federation/update-instance エンドポイントにリクエストが生じますが、これは不要なリクエストです(非ログインユーザーであれば401、モデレーターでないユーザーであれば403が返ってきます)。

🥰 Expected Behavior

非ログインユーザー、非モデレーターが /instance-info/{host} ページを開いてもこのリクエストが送られない

🤬 Actual Behavior

非ログインユーザー、非モデレーターが /instance-info/{host} ページを開いてもこのリクエストが送られる

📝 Steps to Reproduce

No response

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey: 2024.5.0

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
1 participant