Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getApType()でcannot detect typeエラーになる場合をvoidで返すようにしたい #14239

Closed
1 task
tamaina opened this issue Jul 17, 2024 · 3 comments · Fixed by #14361
Closed
1 task

getApType()でcannot detect typeエラーになる場合をvoidで返すようにしたい #14239

tamaina opened this issue Jul 17, 2024 · 3 comments · Fixed by #14361
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority

Comments

@tamaina
Copy link
Contributor

tamaina commented Jul 17, 2024

Summary

getApType()でcannot detect typeエラーになる場合をvoidで返すようにしたい

Purpose

  • if評価文中でエラーハンドリングが煩雑であるため
  • もっぱらgetApType(activity) === 'Note'というような用途でしか使われないためvoidでも問題なさそう

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@tamaina tamaina added the ✨Feature This adds/improves/enhances a feature label Jul 17, 2024
@tai-cha
Copy link
Contributor

tai-cha commented Jul 18, 2024

あまり母数は多くないけどジョブキューに溜まるので早めに直したい気持ちがややある

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jul 21, 2024 •
edited
Loading

直近のdevelopでメモリ使用量が２～３倍に増加したという声があり、これが原因じゃないかとにらんでいる

@1673beta 1673beta mentioned this issue Aug 3, 2024
Closed
1 task
@kakkokari-gtyih
Copy link
Contributor

キューが詰まる原因になっているっぽいのでやっぱりそうするべきそう

@kakkokari-gtyih kakkokari-gtyih mentioned this issue Aug 4, 2024
Merged
5 tasks
@kozakura913 kozakura913 mentioned this issue Aug 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨Feature This adds/improves/enhances a feature 🔥high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(backend): getApTypeでエラーを投げないように kakkokari-gtyih/misskey
3 participants
@tamaina @tai-cha @kakkokari-gtyih