Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS deprecation warning #14326

Closed
1 task
zyoshoka opened this issue Jul 30, 2024 · 1 comment
Closed
1 task

SCSS deprecation warning #14326

zyoshoka opened this issue Jul 30, 2024 · 1 comment
Labels
⚠️bug? This might be a bug

Comments

@zyoshoka
Copy link
Contributor

zyoshoka commented Jul 30, 2024

💡 Summary

085b3absass のバージョンを上げた影響で

pnpm --filter frontend build

すると以下のような警告が複数出ます。upcoming version非推奨になる挙動が変わるということですので緊急の対応を要するものではなさそうです。

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
20  │ ┌     @media (max-width: 500px) {
21  │ │         --margin: var(--marginHalf);
22  │ │     }
    │ └─── nested rule
... │
25  │       --eventFollow: #36aed2;
    │       ^^^^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    src/style.scss 25:2  root stylesheet

🥰 Expected Behavior

警告がでない

🤬 Actual Behavior

警告がでる

📝 Steps to Reproduce

No response

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey: 2024.7.0-rc.5

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@zyoshoka zyoshoka added the ⚠️bug? This might be a bug label Jul 30, 2024
@kakkokari-gtyih
Copy link
Contributor

Fixed in #14513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

2 participants