Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit failure if checking misskey-js autogen fails #14650

Closed
1 task
zyoshoka opened this issue Sep 29, 2024 · 0 comments · Fixed by #14652
Closed
1 task

Exit failure if checking misskey-js autogen fails #14650

zyoshoka opened this issue Sep 29, 2024 · 0 comments · Fixed by #14652
Labels
🛠️Dev Development of Misskey itself
Milestone
v2024.10.0

Comments

@zyoshoka
Copy link
Contributor

Summary

Check Misskey JS autogen ワークフローで autogen ファイルの整合性が保たれていないことが分かった場合にはコメントを出すだけではなくちゃんと異常終了するようにしたいです。

Purpose

コメントだけだと見落とされてしまう可能性が高い（実際 #14580 ではそのままリリースされました）ので

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@zyoshoka zyoshoka added the 🛠️Dev Development of Misskey itself label Sep 29, 2024
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.10.0 (?) milestone Sep 29, 2024
@anatawa12 anatawa12 mentioned this issue Sep 30, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🛠️Dev Development of Misskey itself
Projects
None yet
Milestone
v2024.10.0
Development

Successfully merging a pull request may close this issue.

Misskey js autogen check improvements anatawa12/misskey
2 participants
@kakkokari-gtyih @zyoshoka