Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore page missing text #7931

Closed
okpierre opened this issue Oct 30, 2021 · 2 comments · Fixed by #7945
Closed

Explore page missing text #7931

okpierre opened this issue Oct 30, 2021 · 2 comments · Fixed by #7945
Labels
⚠️bug? This might be a bug

Comments

@okpierre
Copy link
Contributor

💡 Summary

Explore page missing text

🙂 Expected Behavior

Text is visible when visiting Explore page

☹️ Actual Behavior

Blank space after Remote

Screenshot

misskeyexplore

📝 Steps to Reproduce

  1. Login
  2. Go to Explore
  3. At the top, go to Search

📌 Environment

Misskey 12.94.1 Firefox and Chrome

@okpierre okpierre added the ⚠️bug? This might be a bug label Oct 30, 2021
@Johann150
Copy link
Contributor

Johann150 commented Nov 1, 2021

This is using a missing string both. I think in analogy to these two selection boxes it should use all instead

<MkSelect v-model="targetUserOrigin" style="margin: 0; flex: 1;">
<template #label>{{ $ts.targetUserOrigin }}</template>
<option value="combined">{{ $ts.all }}</option>
<option value="local">{{ $ts.local }}</option>
<option value="remote">{{ $ts.remote }}</option>
</MkSelect>
<MkSelect v-model="reporterOrigin" style="margin: 0; flex: 1;">
<template #label>{{ $ts.reporterOrigin }}</template>
<option value="combined">{{ $ts.all }}</option>
<option value="local">{{ $ts.local }}</option>
<option value="remote">{{ $ts.remote }}</option>
</MkSelect>

diff --git a/src/client/pages/explore.vue b/src/client/pages/explore.vue
index a77b4e53c..5a23d34d2 100644
--- a/src/client/pages/explore.vue
+++ b/src/client/pages/explore.vue
@@ -70,7 +70,7 @@
                                        <MkRadios v-model="searchOrigin">
                                                <option value="local">{{ $ts.local }}</option>
                                                <option value="remote">{{ $ts.remote }}</option>
-                                               <option value="both">{{ $ts.both }}</option>
+                                               <option value="both">{{ $ts.all }}</option>
                                        </MkRadios>
                                </div>

@okpierre
Copy link
Contributor Author

okpierre commented Nov 1, 2021

I also see all being used for files so seems correct. Do you want to submit PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants