Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint broken in 12.103.1? drive/files/create #8243

Closed
ghost opened this issue Feb 1, 2022 · 2 comments
Closed

API endpoint broken in 12.103.1? drive/files/create #8243

ghost opened this issue Feb 1, 2022 · 2 comments
Labels
⚠️bug? This might be a bug

Comments

@ghost
Copy link

ghost commented Feb 1, 2022

💡 Summary

API calls to drive/files/create are no longer working after updating to 12.103.1 and I'm not sure why (can't see error)
After reverting to 12.102.1 they are working again. Can someone please verify if this is a bug with 12.103 or a new change? I'm sorry if it's not a bug and please close this if so. I'm sorry there's not more information.

🙂 Expected Behavior

API call to drive/files/create successfully uploads file.

☹️ Actual Behavior

API call to drive/files/create fails (I'm sorry, I can't tell which error because the exception isn't working either on Misskey.py and I don't know how to do it manually since I am not a coder ><)

📝 Steps to Reproduce

  1. make api call to drive/files/create endpoint with parameters file pointing to a valid image

📌 Environment

Misskey 12.103.1

@ghost ghost added the ⚠️bug? This might be a bug label Feb 1, 2022
@ghost
Copy link
Author

ghost commented Feb 1, 2022

looking back i think this is intended behaviour because of the refactor and the misskey.py itself needs to be updated, so I'm closing it. Sorry!

@ghost ghost closed this as completed Feb 1, 2022
@mei23
Copy link
Contributor

mei23 commented Feb 2, 2022

The parsing method when specifying boolean in multipart/form-data (used in drive/files/create) has changed.

Before

# input string => parsed boolean
true => true
True => false !
false => false
False => false
foo => false

After

true => true
True => (error)
false => false
False => (error)
foo => (error)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

1 participant