Fix rsync --exclude argument (fixes #7320)

[laggingreflex]

No description provided.

[sethvargo]

Hi @laggingreflex

Thank you for the PR. Unfortunately this is not a valid fix (the exclude command does not accept an equals sign) and the build is broken.

[laggingreflex]

I too thought it was weird that putting equal sign fixed the issue for me, but it actually did. I'm on Windows using rsync from Cygwin and rcync -h output tells me to use an equals sign:

    C:\cygwin\bin>rsync
    rsync  version 3.1.2  protocol version 31
    ...
    Options
        ...
         --exclude=PATTERN       exclude files matching PATTERN
         --exclude-from=FILE     read exclude patterns from FILE
         --include=PATTERN       don't exclude files matching PATTERN
         --include-from=FILE     read include patterns from FILE
         --files-from=FILE       read list of source-file names from FILE
        ...

And I even searched around whether it's the correct syntax or not. These docs show in every example that an equals sign is used: https://download.samba.org/pub/rsync/rsync.html

Could it be one of those things that not usually required, but unless a problem like this happens? Maybe it's an issue only on Windows?

[Valgard]

I use rsync on my debian systems and it also requires an equal sign to work correctly.

rsync  version 3.0.9  protocol version 30
...
Options
...
     --exclude=PATTERN       exclude files matching PATTERN
     --exclude-from=FILE     read exclude patterns from FILE
     --include=PATTERN       don't exclude files matching PATTERN
     --include-from=FILE     read include patterns from FILE
     --files-from=FILE       read list of source-file names from FILE
...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.