Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZPA add_segment / update_segment]: tcp and udp pairs. #257

Open
mrpackethead opened this issue Mar 18, 2024 · 1 comment
Open

[ZPA add_segment / update_segment]: tcp and udp pairs. #257

mrpackethead opened this issue Mar 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mrpackethead
Copy link

In zpa app_segments the add_segment and update_segments take a different type for udp and tcp ports.. in add_segments its a list of string, and in update_segment its a list of of tuple pairs..

Is that intentional?

Is it possible to add a segment with a list of tuple pairs? For example, i want to add ports 80 and 443, not the range 80 to 443.

@mrpackethead mrpackethead added the bug Something isn't working label Mar 18, 2024
@mitchos
Copy link
Owner

mitchos commented Apr 7, 2024

Hi @mrpackethead I looked into this and you're right that they're different and yes it will work if we use a list of tuple pairs (pass it as a kwarg tcpPortRange if you need this capability today).

I'm still using the same code from the initial implementation 2 years ago so I think I was going for MVP at that stage vs completely implementing all options. I can't really explain my actions from then 🤷

I've tested it working with the same as the implementation for updating an app segment so I'll go back through that method and bring it up to date with the latest attributes for that ZPA API endpoint. This will be fixed in the next release.

Thanks for flagging.

@mitchos mitchos added enhancement New feature or request and removed bug Something isn't working labels Apr 7, 2024
@mitchos mitchos added this to the 1.7.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants