From 1f3a4f9eb1a5164961d0fc60af9c80bc363b443d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Tue, 19 Oct 2021 22:36:49 +0200 Subject: [PATCH 1/3] Initialize sampleRate --- src/effects/backends/builtin/reverbeffect.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/effects/backends/builtin/reverbeffect.h b/src/effects/backends/builtin/reverbeffect.h index cc9f57ae12c..d3bd1d7ceae 100644 --- a/src/effects/backends/builtin/reverbeffect.h +++ b/src/effects/backends/builtin/reverbeffect.h @@ -19,6 +19,7 @@ class ReverbGroupState : public EffectState { public: ReverbGroupState(const mixxx::EngineParameters& engineParameters) : EffectState(engineParameters), + sampleRate(engineParameters.sampleRate()), sendPrevious(0) { } From 00dad56db5885ec0754fad2cb5e1b0e9a0e09cdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Tue, 19 Oct 2021 22:39:34 +0200 Subject: [PATCH 2/3] Added missing virtual destructor in EffectRequestHandler --- src/engine/effects/message.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/engine/effects/message.h b/src/engine/effects/message.h index 134d2fa4256..c6504ab173f 100644 --- a/src/engine/effects/message.h +++ b/src/engine/effects/message.h @@ -168,4 +168,5 @@ class EffectsRequestHandler { virtual bool processEffectsRequest( EffectsRequest& message, EffectsResponsePipe* pResponsePipe) = 0; + virtual ~EffectsRequestHandler() = default; }; From afc940c1c56a7ddc7b8e9bcb5a5a625a9f578b2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Wed, 20 Oct 2021 22:18:45 +0200 Subject: [PATCH 3/3] Initalize RampedSample::currentValue --- src/effects/backends/builtin/autopaneffect.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/effects/backends/builtin/autopaneffect.h b/src/effects/backends/builtin/autopaneffect.h index 6d96b91f069..8244e6821b6 100644 --- a/src/effects/backends/builtin/autopaneffect.h +++ b/src/effects/backends/builtin/autopaneffect.h @@ -20,6 +20,7 @@ class RampedSample { inline RampedSample() : ramped(false), maxDifference(1.0f), + currentValue(0), initialized(false) { }