Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossfader orientation isn't saved/restored #10122

Closed
mixxxbot opened this issue Aug 23, 2022 · 9 comments · Fixed by #12074
Closed

Crossfader orientation isn't saved/restored #10122

mixxxbot opened this issue Aug 23, 2022 · 9 comments · Fixed by #12074

Comments

@mixxxbot
Copy link
Collaborator

Reported by: mxmilkiib
Date: 2020-09-23T20:02:49Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1896832
Tags: easy, usability


If I set all channels to ignore the crossfader, then quit and restart, the options I had set have reset.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-02-22T00:44:41Z


IIRC the this was supposed to avoids situations after start that are kinda hard to debug. If the orientation switches have been changed unnoticed previously, or 'in the heat of the night'.
Now (2.3) all skins (except Shade) show the crossafder switches both in 2- and 4-deck mode. Only in Tango skin they are in an unusual position, not the mixer, which is also far from the mixer.

There are at least two use cases that are affected by crossfader/orientation persistence. I assume they affect the 4-decks mode only, so we can ignore Shade skin here.

  1. multiple DJs share a computer during a set and want to switch between regular crossfader usage and 'all channels centered, crossfader ignored' without the need to flip all decks switches and show/hide the crossfader via Skin Settings.

For that we could add an option to Preferences > Crossfader called
"Ignore crossfader", plus a CO that can be mapped in skins and on
controllers.
Toggle "Ignore crossfader" ON does

  • (center the crossfader, store position??)
  • store orientation of all decks
  • put all decks into their default position
  • hide the crossfader in skins
  • ignore crossfader input from controllers
    Toggle OFF does
  • restore orientation of all decks
  • (restore crossfader position??)
  • show the crossfader in skins
  1. Save & restore the custom channel orientation across restarts
    Example: outer decks 3/4 are left/right, decks 1+2 are always centered.
    It's tempting to add a respective option into the Decks preferences page
    (default off). But actually, since it's tightly coupled to the crossfader
    and the deck page is crammed already, it should better be in the
    Crossfader page.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-02-22T21:07:15Z


I am leaning towards simply making the crossfader orientation switches persistent in all cases. This is how every 4 deck mixer and controller with crossfader assignment switches works. I think if a user wants to change these, they probably want that change to persist.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@ronso0
Copy link
Member

ronso0 commented Oct 3, 2023

Another request in the forums, for the samplers https://mixxx.discourse.group/t/abs-function-only-working-on-one-sl-1200-turntable/28106/9

@phil-flip
Copy link

Same here!

@ronso0
Copy link
Member

ronso0 commented Oct 7, 2023

Had this change in my stahs list already, here we go #12074

@ronso0
Copy link
Member

ronso0 commented Nov 8, 2023

#12074

@ronso0 ronso0 closed this as completed Nov 8, 2023
@mxmilkiib
Copy link
Contributor

mxmilkiib commented Dec 16, 2023

If this is merged, why am I still having to set the orientation for the 4 decks/channels every time I start Mixxx?

Running 2.4-alpha-1578-gc47f67985d

@ronso0
Copy link
Member

ronso0 commented Dec 16, 2023

Mixxx 2.4 is in beta for quite a while now, your alpha build does appearantly not contain the fix. FWIW I stumbled over the fix recently while testing something else XD

@mxmilkiib
Copy link
Contributor

Oooh, there is no branch specified in the PKGBUILD, so it's using main, and that's older, I missed that!

I'll fix the mixxx-git-debug PKGBUILD that I'm using and that's in the AUR for Arch users.

And yay that it is actually fixed, ty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants