Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX parameters reset after "OK" in preferences #10388

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

FX parameters reset after "OK" in preferences #10388

mixxxbot opened this issue Aug 23, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: toszlanyi
Date: 2021-04-07T06:17:47Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1922854
Tags: effects, preferences
Attachments: [This little screendump shows the effect](https://bugs.launchpad.net/bugs/1922854/+attachment/5485058/+files/This little screendump shows the effect)


effects.xml should always store FX parameters until I change them inside the GUI. That unfortunately never worked for me. Was long time on KDE neon, then interim on Manjaro and now running EndeavourOS. Always the same issue, FX are reset to default parameter settings randomly, e.g. when closing Mixxx and start it up again. If several items are changed in the preferences window then this bug can be reproduced. I tried with changing sound output, change Live stream from one to another and even changing the default color for the Hot Cue resets FX parameters when pressing OK in the preferences window. It does not reset when pressing Apply though.

Depending on the FX used this can lead to disturbed or no sound during a Mixxx session (e.g. the moog filter defaults to LPF=0 that results in no sound at all)

Solution:

  • Keep FX parameters unaffected by other changes in Mixxx
  • set all parameters to default values that DO NOT change / transform sound

I tried with 2.3.0-beta (build makepkg r8110) & latest Beta (downloaded Apr, 7th).

Bug #⁠1795661 was similar but closed without solution

PR #⁠2618 seems to resolve the issue but is targeted towards Mixxx 2.4. When trying the PR #⁠2618 I only checked for updates inside the Preferences window but not long term about FX parameters reset over sessions periodically.

This should be treated as critical bug because it can harm a live session if one must change a setting in preferences while playing.

Edit: The log file doesn't show anything about this behavior.

@mixxxbot
Copy link
Collaborator Author

Commented by: toszlanyi
Date: 2021-04-07T06:18:47Z
Attachments: [This little screendump shows the effect](https://bugs.launchpad.net/mixxx/+bug/1922854/+attachment/5485058/+files/This little screendump shows the effect)

@mixxxbot
Copy link
Collaborator Author

Commented by: toszlanyi
Date: 2021-04-07T06:57:05Z


Bug #⁠1803580 seems similar. In there is a solution to avoid changes of FX parameters when preferences are changed.

-> In Preference window press Apply and Esc instead of OK.

To solve the periodically occurrence when restart Mixxx you can setup your FX parameters and then copy effets.xml to a separate file, e.g. effects.default. Now start Mixxx with a little bash script that copies the default settings first to the original file before launching Mixxx.

for Linux based OS this could look like:

#!/bin/bash
cp ~/.mixxx/effects.default ~/.mixxx/effects.xml
mixxx

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-05-18T07:35:59Z


I can confirm this with the current 2.3 beta

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-05-19T23:24:25Z


Is this reproducible with Mixxx' built-in effects only or with external LV2 effects involved?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-05-20T05:24:07Z


I can confirm this with internal effects only.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2021-11-21T01:13:18Z


shold be fixed by #2618
#4467 respectively

PLease re-open if you can still reproduce it.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant