can't create new mapping with wizard from scratch

[mixxxbot]

Reported by: ywwg
Date: 2021-09-26T15:14:43Z
Status: Confirmed
Importance: Medium
Launchpad Issue: lp1945109
Tags: controllers, preferences

---

I have a controller that is not supported by Mixxx. I'd like to start mapping by using the midi mapping wizard, but the Wizard button is disabled unless a mapping is selected. This is a paradox. A simple workaround would be to create a new preset called "Blank Midi Mapping" with nothing configured. (easy starter bug!)

[mixxxbot]

Commented by: ronso0
Date: 2021-09-26T16:38:02Z

---

Confirmed. I noticed it with the MIDI Through, though:

• enable MIDI Through, Apply
  = Wizard button is not activated
• close + open preferences
  = Wizard button enabled

[mixxxbot]

Commented by: ronso0
Date: 2021-09-26T16:54:47Z

---

maybe this and https://bugs.launchpad.net/mixxx/+bug/1945108
are related to incorrect isDirty(), see
https://bugs.launchpad.net/mixxx/+bug/1920844
([unchanged] mapping is reload when clicking Okay in any other page)

[mixxxbot]

Commented by: Be-ing
Date: 2021-09-26T18:26:03Z

---

Is this on the main branch or 2.3? I am pretty sure we solved a regression with this during the 2.3 beta period, but it's plausible that refactoring on the main branch created a separate regression.

[mixxxbot]

Commented by: ronso0
Date: 2021-09-26T21:29:15Z

---

I noticed it on main.

btw the bug occurs also the other way around:
disable a controller, Apply and the Wizard button is still enabled and would also start the wizard (after being prompted to Apply the 'changes')

[mixxxbot]

Commented by: ronso0
Date: 2021-09-27T01:45:11Z

---

After a quick check I think it's just that the Wizard button needs to be updated in slotApply, not just in slotUpdate.