Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master EQ does not work in the effects_refactoring branch #10562

Closed
mixxxbot opened this issue Aug 23, 2022 · 3 comments
Closed

Master EQ does not work in the effects_refactoring branch #10562

mixxxbot opened this issue Aug 23, 2022 · 3 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2021-10-18T10:12:46Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1947570


It is still working as desired in 2.3 and main.

I have configured the EQ in all three branches with the "Graphic Equalizer" and made a CO Dump.
This has discovered no differences. So I assume the preferences setting is still working but there must be an issue with processing the effect unit.

If one likes to pick this bug up, it should be issued against the https://github.com/mixxxdj/mixxx/tree/effects_refactoring branch and not the unhandy big #2618

Since the main EQ is not a show stopper feature the effects_refactoring branch can be merged without the bug fixed. However this will block a 2.4 beta release which is already overdue.

Are there objections?

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-10-18T10:48:25Z


However this will block a 2.4 beta release which is already overdue.

No beta date has been agreed to. Please stop saying these things.

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2021-10-22T19:41:07Z


#4471

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant