Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect buffer not reset after eject #10692

Closed
mixxxbot opened this issue Aug 23, 2022 · 2 comments
Closed

Effect buffer not reset after eject #10692

mixxxbot opened this issue Aug 23, 2022 · 2 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: daschuer
Date: 2022-03-27T19:56:14Z
Status: In Progress
Importance: High
Launchpad Issue: lp1966607


If you enable the echo and then eject the track, echo stops immediately, which is OK.

The issue is if you later load a new track the echo of the old track continues, even if the new track is not yet playing. Since the echo is mixed in post fader, it is played straight out to master and you have no chance to intuitively silence it by the line fader.

Disabling the effect solves the issue.

This was tested with 2.3.2 and 2.4 alpha

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@ronso0 ronso0 changed the title Effect buffernot reset after eject Effect buffer not reset after eject Sep 22, 2022
@ronso0
Copy link
Member

ronso0 commented Sep 22, 2022

#4707

@daschuer
Copy link
Member

Fixed in #4707

@fwcd fwcd added the effects label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants