Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track operation progress dialog broken for "Remove from Disk" #10763

Closed
mixxxbot opened this issue Aug 23, 2022 · 3 comments
Closed

Track operation progress dialog broken for "Remove from Disk" #10763

mixxxbot opened this issue Aug 23, 2022 · 3 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2022-06-28T13:13:31Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1980091
Tags: library
Attachments: Screenshot_2022-06-28_13-27-36.png


tested with 1 track:

  • click Delete from Disk in the track menu (deck or tracks table)

  • confirm

  • file is deleted, track is purged

  • delete success notice pops up

  • wait > 2s (TaskMonitor::kDefaultMinimumProgressDuration?)

  • progress dialog pops up
      - placeholder %1 is not replaced with track count
      - progress bar stuck at the left
      - blocks success dialog

    If the success notice is confirmed within < 2s and there will be no progress dialog.

If two tracks are removed, the delayed dialog is stuck at 50% (and also shows the %1 placeholder.

Seems that the track batch process timer is still running after applyTrackPointerOperation() has finished but the TrackPointerOperation is not deleted?
slotRemoveFromDisk is the only slot that does stuff after applyTrackPointerOperation() has finished so I guess this bug can only be reproduced there.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-06-28T20:43:53Z
Attachments: Screenshot_2022-06-28_13-27-36.png

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2022-06-29T08:22:37Z


#4831

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant