Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixxx crashes when click on a track updated with Musicbrainz Metadata #10782

Closed
mixxxbot opened this issue Aug 23, 2022 · 4 comments
Closed

Mixxx crashes when click on a track updated with Musicbrainz Metadata #10782

mixxxbot opened this issue Aug 23, 2022 · 4 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: fatihemreyildiz
Date: 2022-07-08T19:20:24Z
Status: Fix Committed
Importance: Undecided
Launchpad Issue: lp1981106


I am having an interesting error. Since I am playing with the "import metadata from musicbrainz" button a lot I was having an critical error and Mixxx was crashing very often. I thought it was because the changes I did on while I am trying to add cover art fetcher. I changed my branch to upstream/main, I was having the same error. So I decided to take a look.

It is happening after I click a track which is updated with a new metadata.
What is happening:
I update a track with "Import Metadata from Musicbrainz"
I apply the changes.
I click on the song which is updated on the track library and Mixxx crashes.

The error is:
critical [Main] DEBUG ASSERT: "getSourceSynchronizedAt() <= fileSourceSynchronizedAt" in function mixxx::TrackRecord::SourceSyncStatus mixxx::TrackRecord::checkSourceSyncStatus(const mixxx::FileInfo&) const at /home/whoami/mixxx/src/track/trackrecord.cpp:175

So I commented that block of code in the function, I started to not have this error. I think it is related with the debug mode, and for developers to notice. I have also tried without developer mode, there was no error.

The function is:

TrackRecord::SourceSyncStatus TrackRecord::checkSourceSyncStatus(

@mixxxbot
Copy link
Collaborator Author

Commented by: fatihemreyildiz
Date: 2022-07-08T19:33:24Z


I am not sure if it is even a bug, or an important bug. @uklotzde Could you please take a look? Thanks in advance.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2022-07-08T22:47:57Z


#4847

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2022-07-08T22:49:06Z


Thanks for reporting this. We didn't consider a valid use case and this should not be a debug assertion. I wonder why no one has discovered that yet.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant