Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show meaningful value for effect parameters #11040

Closed
ronso0 opened this issue Nov 5, 2022 · 1 comment
Closed

Show meaningful value for effect parameters #11040

ronso0 opened this issue Nov 5, 2022 · 1 comment
Labels
changelog This PR should be included in the changelog confirmed effects feature gui
Milestone

Comments

@ronso0
Copy link
Member

ronso0 commented Nov 5, 2022

Feature Description

Example:
show actual Hz value for the low and high pass cutoff of the built-in filter effects

Good: Parametric EQ

EffectManifestParameterPointer center1 = pManifest->addParameter();
center1->setId("center1");
center1->setName(QObject::tr("Center 1"));
center1->setShortName(QObject::tr("Center 1"));
center1->setDescription(QObject::tr(
"Center frequency for Filter 1, from 100 Hz to 14 kHz"));
center1->setValueScaler(EffectManifestParameter::ValueScaler::Logarithmic);
center1->setUnitsHint(EffectManifestParameter::UnitsHint::Hertz);
center1->setNeutralPointOnScale(0.5);
center1->setRange(100, kDefaultCenter1, 14000);

Not so good: MoogLadder4Filter

static constexpr double kMinCorner = 0.0003; // 13 Hz @ 44100
static constexpr double kMaxCorner = 0.5; // 22050 Hz @ 44100

lpf->setUnitsHint(EffectManifestParameter::UnitsHint::Unknown);
lpf->setDefaultLinkType(EffectManifestParameter::LinkType::LinkedLeft);
lpf->setNeutralPointOnScale(1);
lpf->setRange(kMinCorner, kMaxCorner, kMaxCorner);

@ronso0
Copy link
Member Author

ronso0 commented Sep 27, 2023

Fixed by #11041 I think

@ronso0 ronso0 closed this as completed Sep 27, 2023
@ronso0 ronso0 added the changelog This PR should be included in the changelog label Sep 27, 2023
@ronso0 ronso0 added this to the 2.4.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog confirmed effects feature gui
Projects
None yet
Development

No branches or pull requests

2 participants