Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing "Album Artist" will not be cleared by "Import From File Tags" when that field is cleared by another tag editor #11241

Open
atskler opened this issue Feb 2, 2023 · 4 comments

Comments

@atskler
Copy link

atskler commented Feb 2, 2023

Bug Description

Existing "Album Artist" will not be cleared by "Track > Right click > Metadata > Import From File Tags" when that field is cleared by another tag editor. (This works correctly with the "Comment" field.)

Version

2.3.3-121-gd1f63374fc

OS

OpenSUSE Tumbleweed

@daschuer
Copy link
Member

daschuer commented Feb 2, 2023

I think we need to treat a missing "Album Artist" as an empty string and not as "unknown" null value where the Mixxx value is adopted.

@uklotzde
Copy link
Contributor

uklotzde commented Feb 5, 2023

I think we need to treat a missing "Album Artist" as an empty string and not as "unknown" null value where the Mixxx value is adopted.

No. The check for reading ID3v2 comment frames is wrong, should be isEmpty() instead of isNull() for consistency. Resetting missing/empty properties on import is controlled by resetMissingTagMetadata.

@uklotzde
Copy link
Contributor

uklotzde commented Feb 5, 2023

The only feature that is missing is a UI option for kResetMissingTagMetadataOnImportConfigKey.

This is also a legit reason for keeping the Easy tag on this issue.

@atskler
Copy link
Author

atskler commented Jul 14, 2023

The main issue is present in 2.4 beta.
Cleared the Album Artist field in foobar2000 but Mixxx will not clear it when I click Metadata, Import from file tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants