Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View menu hotkeys don't work after toggling fullscreen on Ubuntu 22.04 #11281

Closed
ronso0 opened this issue Feb 16, 2023 · 0 comments
Closed

View menu hotkeys don't work after toggling fullscreen on Ubuntu 22.04 #11281

ronso0 opened this issue Feb 16, 2023 · 0 comments
Labels
Milestone

Comments

@ronso0
Copy link
Member

ronso0 commented Feb 16, 2023

Bug Description

all other main menu hotkeys/actions that are not VisibilityControlConnection still work.

So it's the 'menubar missing' workaround causing this

mixxx/src/mixxx.cpp

Lines 1425 to 1450 in 620242d

void MixxxMainWindow::slotViewFullScreen(bool toggle) {
if (isFullScreen() == toggle) {
return;
}
if (toggle) {
showFullScreen();
#ifdef __LINUX__
// Fix for "No menu bar with ubuntu unity in full screen mode" Bug
// #885890 and Bug #1076789. Before touching anything here, please read
// those bugs.
createMenuBar();
connectMenuBar();
if (m_pMenuBar->isNativeMenuBar()) {
m_pMenuBar->setNativeMenuBar(false);
}
#endif
} else {
#ifdef __LINUX__
createMenuBar();
connectMenuBar();
#endif
showNormal();
}
emit fullScreenChanged(toggle);
}

Version

2.3.3, and newer as well IIRC

OS

Ubuntu 22.04 with Unity desktop

@ronso0 ronso0 added the bug label Feb 16, 2023
@ronso0 ronso0 linked a pull request Feb 17, 2023 that will close this issue
6 tasks
@ronso0 ronso0 added this to the 2.3.4 milestone Feb 17, 2023
@ronso0 ronso0 changed the title View menu hotkeys don't work after toggling fullscreen on Ubuntu 22.04 with Unity desktop View menu hotkeys don't work after toggling fullscreen on Ubuntu 22.04 Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants