Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSL Waveforms disappear on resize #11786

Closed
tgucio opened this issue Aug 3, 2023 · 6 comments
Closed

GLSL Waveforms disappear on resize #11786

tgucio opened this issue Aug 3, 2023 · 6 comments

Comments

@tgucio
Copy link

tgucio commented Aug 3, 2023

Bug Description

When resizing the window on a large 4k display on a MacBook Pro M1, beyond certain size the waveforms disappear:

mixxx-waveform

HW: MacBook Pro 14", 2021 (Apple M1 silicon), macOS Ventura 13.4.1 (c) (22F770820d)
Mixxx version: 2.4-beta-70-g2e3d72f479

Version

2.4-beta-70-g2e3d72f479 (Apple silicon build)

OS

macOS Ventura 13.4.1 (c) (22F770820d) (Apple M1 silicon)

@tgucio tgucio added the bug label Aug 3, 2023
@tgucio tgucio changed the title Waveforms disappears on resize Waveforms disappear on resize Aug 3, 2023
@JoergAtGithub
Copy link
Member

@m0dB Could you've a look

@m0dB
Copy link
Contributor

m0dB commented Aug 4, 2023

Hi, I am on holidays and not near a system where I can try to reproduce this. @tgucio are you building mixxx yourself and able / willing try out some things? I would like to know which of the layers (aka renderers) that make up the waveform display cause this issue. But first of all: does this happen with all waveform types?

@tgucio
Copy link
Author

tgucio commented Aug 4, 2023

@m0dB The problem with building is that I don't have an Intel silicon Mac to build on - I take it building on M1/M2 is still not supported officially (I'm getting some failures building fwcd/m1xxx now).

I've experimented a bit with waveform types and here's what I see:

NOK:

  • Filtered (GLSL)
  • RGB (GLSL)
  • RGB Stacked (GLSL)

OK (not reproduced):

  • Filtered (GL)
  • Filtered (all-shaders) (GLSL)
  • RGB (GL)
  • RGB (all-shaders) (GLSL)
  • RGB L/R (all-shaders) (GLSL)
  • Simple (GL)
  • Simple (all-shaders) (GLSL)

@JoergAtGithub JoergAtGithub changed the title Waveforms disappear on resize GLSL Waveforms disappear on resize Aug 4, 2023
@JoergAtGithub JoergAtGithub added this to the 2.4.0 milestone Aug 4, 2023
@foss-
Copy link
Contributor

foss- commented Aug 6, 2023

Another data point: Can't reproduce on
macOS 13.5 (Intel mac)
2.4-beta-75-gc3df3da55d
Tried all three NOK waveforms and resizing on an external 4k monitor.

@m0dB
Copy link
Contributor

m0dB commented Aug 12, 2023

Seeing that the "all-shaders" waveforms behave fine, I don't see a reason to investigate this further. Instead, we should just recommend (and default to) the all-shaders waveform types, at least on macOS.

@daschuer
Copy link
Member

daschuer commented Sep 3, 2023

We will remove the legacy GLSL Waveforms soon.

@daschuer daschuer closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants