Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library interaction controller COs not working on QT6 / noQML build #11854

Closed
ywwg opened this issue Aug 22, 2023 · 4 comments · Fixed by #11877
Closed

library interaction controller COs not working on QT6 / noQML build #11854

ywwg opened this issue Aug 22, 2023 · 4 comments · Fixed by #11877
Labels
bug control objects Issues and bugs specifically in regard to mixxx `ControlObjects` controller mappings QT6

Comments

@ywwg
Copy link
Member

ywwg commented Aug 22, 2023

Bug Description

I have controller encoders bound to navigate the library -- up, down, load track, change focus, etc. In a QT6 build, these bindings stop working and have no effect. I believe these COs emit keyboard events to cause the UI changes? That might be what broke

Version

HEAD

OS

Ubuntu 22.04

@ywwg ywwg added bug controller mappings control objects Issues and bugs specifically in regard to mixxx `ControlObjects` QT6 labels Aug 22, 2023
@ywwg
Copy link
Member Author

ywwg commented Aug 22, 2023

Added a new QT6 label because I suspect that will be useful :)

@ronso0
Copy link
Member

ronso0 commented Aug 22, 2023

many (all?) library controls are guarded by
Qt version < 6.0 https://github.com/mixxxdj/mixxx/blob/main/src/library/librarycontrol.cpp because Qt6 was assumed to build the Qml library, but does now build the legacy interface hy default?
So replacing these guards with #ifdef QML, if that exists, would enable them again.

@ronso0
Copy link
Member

ronso0 commented Aug 22, 2023

It's #ifndef MIXXX_USE_QML
Dunno why that was not changed in #11608 -> 3d1c7a6

Changing the remainders is a no-brainer. Is someone already fixing this?

@fwcd
Copy link
Member

fwcd commented Aug 27, 2023

Not sure, but I stumbled upon this and couldn't find anything, so I opened #11877. I've only updated the controller-related #ifs, since I wasn't sure about the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug control objects Issues and bugs specifically in regard to mixxx `ControlObjects` controller mappings QT6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants