Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make skin parser warnings less verbose, shorten/omit file path #11974

Open
ronso0 opened this issue Sep 12, 2023 · 0 comments · Fixed by #12253
Open

make skin parser warnings less verbose, shorten/omit file path #11974

ronso0 opened this issue Sep 12, 2023 · 0 comments · Fixed by #12253

Comments

@ronso0
Copy link
Member

ronso0 commented Sep 12, 2023

Currently, skin warnings look like this:

warning [Main] /home/ronso/Downloads/mixxx_source/src/master/src/skin/legacy/legacyskinparser.cpp:2180 SKIN ERROR at skin:../LateNight/controls/knob_with_label.xml:24 <KnobComposed>: Invalid <TooltipId> in skin.xml: "nonsens"

Who cares about the file path? How hard is it to change the SKIN_WARNING macro so it prints the classname only

warning [Main] LegacySkinParser:2180 SKIN ERROR at skin:../LateNight/controls/knob_with_label.xml:24 <KnobComposed>: Invalid <TooltipId> in skin.xml: "nonsens"

Still very long but much less noise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change SKIN_WARNING to show the skin file:line first, then c++ context ronso0/mixxx
1 participant
@ronso0