Controller rate slider can't catch out of bounds position

[ronso0]

This doesn't work anymore:

• move rate slider outside the configured rate range, e.g. -12%, with +- buttons, sync or by setting rate with a controller script
• move controller rate slider to +8%
• = GUI rate slider snaps back to +8%

[ronso0]

I don't see any relevant recent changes in src/engine/controls/ratecontrol.cpp, though I do remember that @ywwg touched something in a PR about 1-2 years ago that would cause exactly this behaviour (that change was reverted), but I don't remember where in the source that was.

[ronso0]

Only workaround I could think of was to disable softTakeover for the rate slider.

[daschuer]

I guess you mean this change:
0fc7bf9

The issue is that you can go from -1 to +1 with your controller. If you go to +1.5 for instance you are no longer able to cross this position and snap back in. I am unsure if that has ever worked. but I think it is reasonable to bypass softcover in the parameter range blow 0 and above 1. Maybe in a way that if you hint the extremes of your slider the out of bound values are catches back.

The code is here:

mixxx/src/controllers/softtakeover.cpp

Line 83 in 0fecdbf

bool SoftTakeover::ignore(ControlObject* control, double newParameter) {

This means in your initial example:

• move rate slider outside the configured rate range, e.g. -12%, with +- buttons, sync or by setting rate with a controller script
• move controller rate slider to +8% -> nothing happens
• move controller rate slider to -8% -> -8% is adopted when reaching the top of the slider.
• move controller rate slider to +8% again -> GUI slider follows

[ronso0]

Thanks for the pointers!

This has worked for years with my branch based on 2.4. I'm pretty sure it still worked with my second last rebase 1-2 months back, and it stopped working after I rebased 1-2 weeks ago.

[daschuer]

I cannot reproduce the issue. The slider snaps fine.
I have also added a unit-test that confirms that.
#12114

Is something else required to reproduce the issue?

[ronso0]

I haven't been to the lab/studio/club lately to test with my controller.
I hope I find time to do it next week. Maybe it's just an issue with my controller or my mapping (even though I'm pretty sure I didn't touch the pitch slider code). Will see..

[ronso0]

Strange, it works as expected with 2.4, main and my production branch based on main.
Can't tell why it failed last time 🤷
Thanks for the pointers @daschuer