Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent Preview deck controls #12925

Open
ronso0 opened this issue Mar 5, 2024 · 2 comments
Open

inconsistent Preview deck controls #12925

ronso0 opened this issue Mar 5, 2024 · 2 comments
Labels

Comments

@ronso0
Copy link
Member

ronso0 commented Mar 5, 2024

I noticed an incosistency:

  • the Preview delegate does either cue_gotoandplay or play (pause)
  • the preview Play button is mapped to play and start (right-click) (and the tooltip says cue_gotoandplay (LateNight only))
  • P is mapped to LoadSelectedTrackAndPlay = jumps to selected load point + starts playing
  • Shift+P is mapped to start_stop (stop + jump to start)

Possible fixes:

  • map the Play button right-click and Shift+P to cue_gotoandstop
    If the user wants to go back to the the start this can be done by dragging the playhead on the overview, while otoh jumping to Cue requires to click the C icon (which is rather small in the preview deck).
    For unprepared tracks Cue = start, and for prepared tracks we may assume Cue has been set to a different position on purpose.
  • add control player control load_point_gotoandstop (might be the Cue point or some other point selected in Preferences -> Decks) and use for P the Preview delegate
@yatigautam
Copy link

hello, i want to work on this issue and have read and understood the issue really well.
But since i am a beginner i don't exactly know from where to start. Please help me in solving this issue and give some steps to start from.

@ronso0
Copy link
Member Author

ronso0 commented Mar 8, 2024

Thank you for your interest!
However, even though the actual implementation is easy we first need to discuss how to proceed.

If you plan to work on some easy bug for getting started with a GSoC application I rather recommend taking a look at the easy list https://github.com/mixxxdj/mixxx/issues?q=is%3Aissue+is%3Aopen+label%3Aeasy%2Cweekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants