Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host validation for broadcasting profile #13328

Open
acolombier opened this issue Jun 5, 2024 · 4 comments
Open

Host validation for broadcasting profile #13328

acolombier opened this issue Jun 5, 2024 · 4 comments
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case feature preferences usability

Comments

@acolombier
Copy link
Member

Feature Description

Currently, it is possible to create a broadcasting profile with invalid host. This leads to very poor experience and hard to diagnose connectivity issues what trying to go live.

As an UX improvement, we should:

  • Ensure that a host is in a valid format (valid IPv4, IPv6 or domain name)
  • Automatically trim leading and tailing spaces after edit
  • Perform DNS resolution with domain name

This can be performed using QValidator and editingFinished signal

Relates to #13300

@ronso0 ronso0 added preferences usability broadcast Bugs pertaining to streaming radio broadcaster use-case labels Jun 5, 2024
@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 7, 2024

Perform DNS resolution with domain name

That would fail in the usecase where a broadcasting profile is created while the PC is offline ahead of time, potentially leading to a false-negative. Doing this check when starting to broadcast should be sufficient IMO. The other checks are a good idea though (though the rules for URL validation are complicated, so we very much shouldn't try to this ourselves).

@acolombier
Copy link
Member Author

acolombier commented Jun 7, 2024

Some of these validation can be soft and simply display a warning, so we don't block rare cases where one would use non conventional custom domain name or configure the profile while offline or unable to resolve the private domain.

Also, note the validation is for the host and not a URL, which is easier to validate.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 7, 2024

yeah. I'm just not sure if the complexity is worth the feature. I'm just suggesting to KISS unless we're certain its worth it.

@acolombier
Copy link
Member Author

acolombier commented Jun 7, 2024

KISS shouldn't be an excuse to make Mixxx not user friendly IMHO. As we've seen with the issue leading to the features request, there is value and doing such a thing.

Overall, I think there would be value in taking to consideration that not all DJ have extensive knowledge of computers science. Currently, this is a real barrier for DJ considering alternative djing software solutions and have to skip on Mixxx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case feature preferences usability
Projects
None yet
Development

No branches or pull requests

3 participants