Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Transpose / Pitch shift effect #7389

Closed
mixxxbot opened this issue Aug 22, 2022 · 13 comments
Closed

Add a Transpose / Pitch shift effect #7389

mixxxbot opened this issue Aug 22, 2022 · 13 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: rryan
Date: 2014-03-28T14:38:44Z
Status: Fix Committed
Importance: Wishlist
Launchpad Issue: lp1299035
Tags: effects, hackathon


We should package up RubberBand as a transpose effect for pitch shifting.

http://en.wikipedia.org/wiki/Transposition_(music)

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2014-11-20T20:55:22Z


Kicking to 1.13.0 unless there is a candidate for 1.12.0 that emerges soon!

This would be an easy weekend bug for someone to get ramped up (hint hint).

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-09T18:55:58Z


This can be also used to fix Bug #⁠1398299 "pitch knob is too coarse" by adding an additional pitch knob with finer or coarser scale.
This way we need no extra space in The GUI and controlling by Controllers with effect region is possible as well.

We have also not found a place for the helpful sync_key control. This can be also made accessible from an effect Rack.

In a later version, we may also add additional harmonic mixing controls, described here:
http://www.mixshare.com/wiki/doku.php?id=mixing_harmonically

I am thinking about an COs only implementation that just, passes values to the normal deck scaler. This way it will not consume much extra CPU.

For channels without a scaler, we may add a own scaler instance inside the effect.

Anny thoughts?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-09T19:52:55Z


On Dec 9, 2014, at 7:55 PM, Daniel Schürmann wrote:

We have also not found a place for the helpful sync_key control.

What does this exactly?
See my questions in https://bugs.launchpad.net/mixxx/+bug/1300616

We`ll find a place in the skins.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2014-12-09T23:56:05Z


Doesn't this duplicate having a pitch/key knob? What's the use case for having it as a separate effect?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-10T07:21:54Z


For the harmonic mixing use case, we need a control, that is able to tweak < 10 cts. The nearest harmonic key is always <= 2.5 
way. So from this point of view, a 0,05 ct click and +- 3,2 halftones knob should be sufficient.   
For a chipmunk effect, the current +- 12 halftones scale is just fine. 

So we may decide to use the fine scale on a permanent knob and move the coarse knob to an effect Rack. We may also duplicate the fine knob for users who wish to have a shared FX/Pitch knob on the controller.  
This will also reduce the need for a pitch knob in all skins. 

We may also implement a two buttons to shift a track by 5 halftones Up and down (or other fixed jumps). This allows to produce cool chord effects during mixing.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-01-28T00:38:00Z


Doesn't this duplicate having a pitch/key knob? What's the use case for having it as a separate effect?

I am not aware of any controller that has a dedicated key knob, but plenty of controllers have effects controls.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-11-11T14:36:36Z


There has been no progress on this lately, so I am removing the 2.1.0 milestone.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-12-28T02:24:59Z


Any volunteers to take this up for 2.2? I had thought about implementing this as a hack that controls the input channel's key knob to save CPU use, but that would only work if the pitch shifting effect was loaded in the first spot in the chain.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-12-28T09:37:40Z


An other use case could be a tempo locked key wobbling, like auto tune effect.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-12-28T13:43:33Z


That is a cool idea!

@mixxxbot
Copy link
Collaborator Author

Commented by: davidchocholaty
Date: 2022-05-30T16:08:49Z


The independent pitch shift effect feature will be implemented as a part of the Google Summer of Code 2022 project.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-05-31T21:13:13Z


#4775

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot mentioned this issue Aug 24, 2022
@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant