Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual duck not works #8995

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed

Manual duck not works #8995

mixxxbot opened this issue Aug 23, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: zaczy
Date: 2017-12-08T08:21:21Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1737113
Tags: microphone, usability


Option "Manual duck" seems to not work at all, while using Microphone to broadcast radio. When I press "Talk" background music level doesn't change - on recorded "audition" results of "Manual duck" and "Duck off" are completely the same.

System: Windows 10 Pro
CPU: Intel i5
Soundcard: Realtek (built in into Dell Inspiron)
Microphon: Trust Emitel USB

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-12-14T18:06:39Z


Thanks for reporting this bug.

Which skin do you use?

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-12-20T13:35:28Z


Manual ducking lowers the volume of everything but the mics by the amount determined by the ducking Strength knob. If you want to adjust how much the music is reduced in volume, turn the Strength knob.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-04-09T20:12:08Z


I poked around a bit in the enginetalkover code, just to find out that the Strength knob works exactly the opposite in AUTO mode than it does in MANUAL mode:
MANUAL strength=0 > max music ducking, strength=1 > no ducking
AUTO strength=0 > no ducking, strength=1 > max ducking

This is confusing and also not reflected in the tooltip.
We should decide for eiter way, and I find the way it works in MANUAL mode right now more intuitive: Strength knob is kinda like a music Vol knob.

Don't know if that's the issue @zaczy experienced, but it's a bug.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2020-04-09T20:30:07Z


That is confusing. I think it would make sense to invert one of them.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-05-07T07:48:41Z


I think we should backport your fix to 2.2 as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-05-07T07:50:42Z


The original PR is here:
#2750
the backport is here:
#2759

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.2.4 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant