New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixxx may crash when importing TagLib ID3v2 APIC frames #9325

Closed

mixxxbot opened this issue Aug 23, 2022 · 2 comments

Labels

bug metadata party stopper

Milestone

Collaborator

mixxxbot commented Aug 23, 2022

Reported by: uklotzde
Date: 2018-06-02T15:05:49Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp1774790
Tags: metadata

Mixxx may crash when reading TagLib ID3v2 APIC frames if their runtime type differs from the compile time expectations, e.g. when an APIC frame is actually not a TagLib::ID3v2::AttachedPictureFrame.

Reported in the forums:
https://www.mixxx.org/forums/viewtopic.php?f=3&t=11872&p=38590#p38585

Solution:
We need to use a dynamic_cast at runtime instead of a static_cast at compile time to identify the actual type of a frame and prevent crashes caused by corrupt or malformed files.

mixxxbot added bug metadata party stopper labels

Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: uklotzde
Date: 2018-06-02T15:30:21Z

Collaborator Author

mixxxbot commented Aug 23, 2022

Issue closed with status Fix Released.

mixxxbot closed this as completed

mixxxbot transferred this issue from another repository

mixxxbot added this to the 2.1.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment