New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FX1/2 buttons missing Mic unit in Deere (64 samplers) #9703

Closed

mixxxbot opened this issue Aug 23, 2022 · 3 comments

Labels

Milestone

Collaborator

mixxxbot commented Aug 23, 2022

Reported by: ronso0
Date: 2019-07-24T10:14:21Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1837716
Tags: skin

reported in https://www.mixxx.org/forums/viewtopic.php?f=8&t=12822

I don't get why the FX buttons are missing in Deere64, because both Deere & Deere64 use the same template Mic units.

mixxxbot added bug skin labels

Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: ronso0
Date: 2019-07-24T10:24:25Z

this is cuased by unneeded SizePolicy here https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/microphone.xml#L94 and here https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/microphone.xml#L111

While looking into this I found that some bugs creeped in skin.xml & skin_settings.xml in both Deere/Deere64, maybe merging of 2.2 into master?

I'll take care of this soonish

Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: ronso0
Date: 2019-07-30T14:29:41Z

Mic FX fix
#2217

fix for diverged skin.xml
#2218

Collaborator Author

mixxxbot commented Aug 23, 2022

Issue closed with status Fix Released.

mixxxbot closed this as completed

mixxxbot transferred this issue from another repository

mixxxbot added this to the 2.2.2 milestone

ronso0 added skins and removed skin labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment