Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open cover art view after single-click release #9746

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Closed

open cover art view after single-click release #9746

mixxxbot opened this issue Aug 23, 2022 · 5 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2019-09-19T21:15:09Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1844730
Tags: coverart, usability


Like the track title and artist widgets, a deck cover art can be dragged to other decks, samplers or somewhere in the library.
Currently the cover art window opens on mouse button PRESS which partially covers the GUI and thereby blocks certain areas for drag moves.

open cover art view not before single-click is released to keep the view clean for drag movements.
Usual longpress timeout should be apllied.

It could also open if the pointer is still above same widget when being released, but that would still/again be the case when when aborting a drag move. Opening the cover art wouldn't be helpful then.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-22T15:20:54Z


quick solution:
* in mousePressEvent() in wcoverart.cpp
  if (event->button() == Qt::LeftButton) {
    start longpress timer;}
* add mouseReleaseEvent() {
  if (event->button() == Qt::LeftButton && timer not expired yet) {
    stop timer, delete timer;
    open cover art window;}}

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-23T20:22:06Z


#2296

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-09-24T06:19:09Z


What is the issue you are trying to solve here?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2019-09-24T13:30:57Z


description updated, sorry for not being clear.

Currently the cover art window opens on mouse button PRESS which partially covers the GUI and thereby blocks certain areas for cover art drag moves.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant