tango settings menu UI issues

[mixxxbot]

Reported by: foss-4
Date: 2019-11-10T14:02:50Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1851994
Tags: skin
Attachments: [tango settings menu UI issues.png](https://bugs.launchpad.net/bugs/1851994/+attachment/5304218/+files/tango settings menu UI issues.png), [OK 10.15.2 mixxx master 2020-01-17.png](https://bugs.launchpad.net/bugs/1851994/+attachment/5321137/+files/OK 10.15.2 mixxx master 2020-01-17.png)

---

macOS 10.14.6
mixxx 2.3.0-alpha-pre (build master r6987)

tango skin, settings menu has UI issues

• the checkmarks used to display an active setting is too big and poorly visible in dark mode (or default mode?)
• the text alignment when active and inactive settings are next to each other is cut off / misaligned (seems again to be caused by the oversized checkmark icon used for active settings
• it would be better if the active settings would use a checked box (needs to be fixed) and inactive settings are an empty box (as is now)

[mixxxbot]

Commented by: foss-4
Date: 2019-11-10T14:02:50Z
Attachments: [tango settings menu UI issues.png](https://bugs.launchpad.net/mixxx/+bug/1851994/+attachment/5304218/+files/tango settings menu UI issues.png)

[mixxxbot]

Commented by: ronso0
Date: 2019-11-10T15:31:17Z

---

looks like Ubuntu font isn't imported.
Can you somehow make sure it's included?

Besides, #2337 should improve the menu and avoid squeezed rows when there's enough space like on your screen.

[mixxxbot]

Commented by: ronso0
Date: 2019-11-26T08:37:26Z

---

@foss-4 Did you check if Mixxx installs Ubuntu font?

The skin changes I mentioned are now in #2363
if you can please test if the issue is solved with this branch.

[mixxxbot]

Commented by: foss-4
Date: 2020-01-17T13:20:45Z
Attachments: [OK 10.15.2 mixxx master 2020-01-17.png](https://bugs.launchpad.net/mixxx/+bug/1851994/+attachment/5321137/+files/OK 10.15.2 mixxx master 2020-01-17.png)

---

Interesting finding as #2363 is not yet merged.

macOS 10.15.2 + mixxx 2.3.0-alpha-pre (build master r7076)

skin preferences for tango are now displayed correctly (see attached screenshot).

[mixxxbot]

Commented by: foss-4
Date: 2020-01-17T13:22:17Z

---

What's the correct status here? Wonfix? Invalid? Fix commited without a commit isn't really great.

[mixxxbot]

Commented by: ronso0
Date: 2020-01-18T16:15:38Z

---

it would be good to know if the issue was solved by upgrading MacOS or Mixxx.
If it is resolved in MacOS 10.14 as well we can mark it 'Fix committed' even though we can't tell if the fix was maybe in Qt sources or Mixxx

[mixxxbot]

Commented by: foss-4
Date: 2020-01-18T17:09:58Z

---

Interesting
retested old r6987 build which had the problem on macOS 10.14. The problem is gone on 10.15.2 with that build as well.

So probably not solved on macOS 10.14.

[mixxxbot]

Commented by: foss-4
Date: 2020-03-04T13:02:53Z

---

Setting to solved. Unsure if 10.14 users are still affected but problem is gone on 10.15.

[mixxxbot]

Issue closed with status Fix Released.