Support for Windows #250
Merged
Support for Windows #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizdra
commented
Jan 9, 2023
| # so it is difficult to run on windows. Therefore, | ||
| # we are temporarily skipping the E2E test on windows. | ||
| # TODO: Enable E2E test on windows. | ||
| if: ${{ matrix.os != 'windows-latest' }} |
There was a problem hiding this comment.
E2E tests could not be run, but I manually checked that it works. eslint-interactive now works on Windows too 🎉
However, there is a bug that the printing of problem details using the pager does not work on windows. I will fix this later.
Co-authored-by: Daniel Bartholomae <daniel@bartholomae.name>
Co-authored-by: Daniel Bartholomae <daniel@bartholomae.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #217