Added mode, owner_user, and owner_group methods to file

[twolfson]

When writing tests, I was getting frustrated at the poor feedback I was getting for mode, user, and group. For example, in the error below, there is no information about what the current mode is:

expected `File "/etc/ssl/private/twolfson.com.key".mode?("300")` to return true, got false

I saw that we have an mtime method and while I don't know its motivations (kind of hard with no GitHub issues or related PR in the blame =/). However, I gave a shot at adding in mode, owner_user, andowner_group`. In this PR:

• Added mode, owner_user, and owner_group methods to file
• Added tests

[twolfson]

I tried to avoid using let(:stdout) but couldn't seem to get it working otherwise. I'm still not sure how the be_mode and be_owned_by matchers are working =/

[mizzy]

Thanks!

But it would be better that owner_user and owner_group are owner and group
because Chef and Puppet use these words.

https://docs.puppetlabs.com/references/latest/type.html#file
https://docs.chef.io/resource_file.html

[twolfson]

Ah, k. I chose those to keep things consistent in the repo. We could also use an attr_alias but I will update the names to owner/group for now =)

[twolfson]

I have applied the updates to this PR

[mizzy]

Thanks!

One more thing, it would be useful that mode is octal, not string.

[twolfson]

Ah, sure thing. I will update that.

[twolfson]

I started moving to an octal but the error messages from failing test suites have become less useful:

     Failure/Error: its(:mode) { should eq 00644 }

       expected: 420
            got: "644"

The 420 in that statement is 00644 being parsed by Ruby. I suggest we rethink moving from octal to string. If someone wants to use an actual octal, then 00644.to_s should suffice.

[mizzy]

Ah, let me rethink about it. Thanks for reporting!

[twolfson]

Any new thoughts on this?

[mizzy]

Sorry for letting you wait. I didn't think of any good ideas. So I'd like to merge current code.

Could you fix this line to pass tests, please ?
https://github.com/twolfson/serverspec/blob/dev/add.more.file.methods.sqwished/spec/type/base/file_spec.rb#L352

[twolfson]

Oh, heh. I didn't realize I broke the build. Yep, I will push a patch shortly.

[twolfson]

Alright, I have updated the code so it should be green in Travis CI now

[mizzy]

Thanks!

[mizzy]

Released as v2.29.0.