Removed piping results to shasum to avoid test passing incorrectly #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that this was supposed to be some sort of optimisation, but because
h1.exit_status
andh2.exit_status
will always inherit the exit code of the latteropenssl sha -sha512
, the test would pass if both: the certificate and the key were invalid or the files were non-existent.For example the following check always passed:
Removing the pipe solves the problem, but I guess the correct way for such cases should be decided for the whole project. For example to make
run_command
to behave like bash with'set -o pipefail'
.