Normalize openssl issuer and subject #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenSSL < 1.1 (as found on EL7 and older distros) the output was:
issuer=/C=US/O=Let's Encrypt/CN=R3
In OpenSSL >= 1.1 (as found on EL8 and newer distros) the output is:
issuer=C = US, O = Let's Encrypt, CN = R3
This normalizes the output to the old pre-1.1 style. This makes it
easier to write a test that should pass on both platforms.
|
Thanks! |
|
Released as v2.41.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL < 1.1 (as found on EL7 and older distros) the output was:
In OpenSSL >= 1.1 (as found on EL8 and newer distros) the output is:
This normalizes the output to the old pre-1.1 style. This makes it easier to write a test that should pass on both platforms.
The downside of this is that we're normalizing to an older output format, but that makes backwards compatiblity easier. An alternative is to introduce new helpers that are normalized. It may also be a chance to thing you the DN should be presented as an array instead of a single string.