Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text colors are not correct #10

Closed
cilerler opened this issue Sep 25, 2017 · 5 comments · Fixed by #30
Closed

Text colors are not correct #10

cilerler opened this issue Sep 25, 2017 · 5 comments · Fixed by #30

Comments

@cilerler
Copy link

cilerler commented Sep 25, 2017

reference:// mermaid-js/mermaid#570

As you can see it in the screenshot, ALT,OPT,LOOP titles are not visible. (text is there, it is just a dark color which makes it very difficult to read on dark theme.)

2017-09-06_22-07-10

@tylerlong stated
Mermaid has a dark theme which is suitable for dark backgrounds. https://unpkg.com/mermaid@7.0.0/dist/mermaid.dark.css

@mjbvz
Copy link
Owner

mjbvz commented Sep 25, 2017

Can you please share the source of that example. We already use mermaid.dark.css but I suspect some rule is being overridden

@cilerler
Copy link
Author

sequenceDiagram
    participant Service
    participant Provider

    loop Minute query
        Service->> Provider: request Records

        alt is maintenance
            Provider --x Service: response No-Record
        else is page
            Provider --x Service: response Records

            Service ->> Service: locate New Records

            opt new Record exist
                loop Details
                    Service ->> Provider: request Details
                    Provider --x Service: respose Details
                end
            end
        end

        Note right of Service: Wait until<br/>time is up...

    end
Loading

@tylerlong
Copy link

I posted reply to mermaid-js/mermaid#570

Let me know if there is anything else that I can help.

@nihao
Copy link

nihao commented May 16, 2018

I set mermaid.dark.css file to the option of markdown.styles in user settings of vscode.
url for the mermaid.dark.css is: https://unpkg.com/mermaid@7.0.0/dist/mermaid.dark.css

image

but it's not effect

image

@mjbvz
Copy link
Owner

mjbvz commented May 16, 2018

I've picked up 8.0.0-rc.8 and switching to explicitly passing in "theme": "dark" but the new Record exist labels are still black:

screen shot 2018-05-16 at 11 59 08 am

Is this expected @tylerlong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants