Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] rename svg_from_json => to_svg #993

Merged
merged 1 commit into from
Oct 19, 2021
Merged

[refactor] rename svg_from_json => to_svg #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mjx/visualizer/svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ def _make_svg(
return dwg


def svg_from_json(json_data: str, target_idx: Optional[int] = None) -> str:
def to_svg(json_data: str, target_idx: Optional[int] = None) -> str:
proto_data = MahjongTable.json_to_proto(json_data=json_data)
dwg = _make_svg(proto_data, ".svg", target_idx)
return '<?xml version="1.0" encoding="utf-8" ?>\n' + dwg.tostring()
Expand Down